[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969450#comment-16969450
]
Yufei Gu commented on YARN-9537:
--------------------------------
Hi [~cane], sorry to come late. Patch 003 looks good to me overall. Just think
aloud, why this property is cluster level instead of queue level?
There are style issues.
# {{protected static final String AM_PREEMPTION = CONF_PREFIX +
"am.preemption";}} There are two spaces between "String" and "AM_PREEMPTION"
# Do we need this comment? Probably not.
{code:java}
// For test
this.enableAMPreemption = scheduler.getConf().getAMPreemptionEnabled();
{code}
> Add configuration to disable AM preemption
> ------------------------------------------
>
> Key: YARN-9537
> URL: https://issues.apache.org/jira/browse/YARN-9537
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 3.2.0, 3.1.2
> Reporter: zhoukang
> Assignee: zhoukang
> Priority: Major
> Attachments: YARN-9537-002.patch, YARN-9537.001.patch,
> YARN-9537.003.patch
>
>
> In this issue, i will add a configuration to support disable AM preemption.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
