[
https://issues.apache.org/jira/browse/YARN-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969547#comment-16969547
]
Eric Badger commented on YARN-9562:
-----------------------------------
Hey [[email protected]], YARN-9562 Patch 014 combined with YARN-9561 patch
010 _should_ fix the {{nobody}} user issue. I also fixed all other issues that
you mentioned (except the ones I talk about below).
bq. 1) Why is the keystore and truststore needed within
RuncContainerExecutorConfig?
These variables are used in create_local_dirs. I'm not super familiar with the
feature, but I was under the impression that they were not tied to any specific
runtime. So I added them in RuncContainerExecutorConfig so that they would be
passed to the container-executor. All variables are passed via that JSON file
for the container-executor in the case of {{--run-runc-container}}
bq. 2) I'm not a big fan of hard coded mounts like this. This would also be
problematic for systemd based containers where systemd expects /tmp to be a
tmpfs.
What do you suggest as an alternative? Add both /tmp and /var/tmp as tmpfs in
the runC config?
bq. 3) It would be great to track these disabled features for future
implementation.
Agreed. Should I file JIRAs for the features or add comments into the code or
add documentation or what?
bq. I'm fine with leaving reference to the patch to docker_to_squash.py for now
until we have a better story, but I did need to do a few steps to get that tool
working. 1) Create the hdfs runc-root as root 2) install skopeo,
squashfs-tools, and attr.
I should be able to fix 1). For 2), I don't want to attempt to install the
packages for them. I have checks for the first two to error out early if they
aren't installed. I'll add a check for attr as well. Is there anything more to
do to make this more user-friendly?
> Add Java changes for the new RuncContainerRuntime
> -------------------------------------------------
>
> Key: YARN-9562
> URL: https://issues.apache.org/jira/browse/YARN-9562
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Eric Badger
> Assignee: Eric Badger
> Priority: Major
> Attachments: YARN-9562.001.patch, YARN-9562.002.patch,
> YARN-9562.003.patch, YARN-9562.004.patch, YARN-9562.005.patch,
> YARN-9562.006.patch, YARN-9562.007.patch, YARN-9562.008.patch,
> YARN-9562.009.patch, YARN-9562.010.patch, YARN-9562.011.patch,
> YARN-9562.012.patch, YARN-9562.013.patch, YARN-9562.014.patch
>
>
> This JIRA will be used to add the Java changes for the new
> RuncContainerRuntime. This will work off of YARN-9560 to use much of the
> existing DockerLinuxContainerRuntime code once it is moved up into an
> abstract class that can be extended.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
