[ 
https://issues.apache.org/jira/browse/YARN-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970790#comment-16970790
 ] 

Szilard Nemeth commented on YARN-9677:
--------------------------------------

Thanks [~pingsutw] for this contribution and thanks [~pbacsko] for the review!

There were 2 unused imports that I removed, as additional changes to the patch:
1. In TestAoclOutputParser: 
import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.FpgaDevice;

2. Also in TestFpgaDiscoverer: 
import 
org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.FpgaDevice;

I don't think we want to bother branch-3.2 and branch-3.1 patches as this patch 
has many conflicts for branch-3.2.

Committed to trunk and closing this jira.

> Make FpgaDevice and GpuDevice classes more similar to each other
> ----------------------------------------------------------------
>
>                 Key: YARN-9677
>                 URL: https://issues.apache.org/jira/browse/YARN-9677
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: kevin su
>            Priority: Major
>              Labels: newbie, newbie++
>         Attachments: YARN-9677.001.patch
>
>
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.fpga.FpgaResourceAllocator.FpgaDevice
>  is an inner class of FpgaResourceAllocator.
> It is not only being used from its parent class but from other classes as 
> well so we are losing the purpose of the inner class, it does not really make 
> sense.
> We also have 
> org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu.GpuDevice
>  which is a similar class, but for GPU devices.
> What we could do here is to make FpgaDevice a single class and harmonize the 
> packages of these 2 classes, meaning they should be "closer" to each other in 
> terms of packaging.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to