[
https://issues.apache.org/jira/browse/YARN-9697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971342#comment-16971342
]
Bibin Chundatt edited comment on YARN-9697 at 11/11/19 7:03 AM:
----------------------------------------------------------------
[~abmodi]
Few minor Nits:
# NodeQueueLoadMonitor following set is not required , already getting set in
constructor .
{code}
private int numNodesForAnyAllocation =
DEFAULT_OPP_CONTAINER_ALLOCATION_NODES_NUMBER_USED;
{code}
Set to zero should be fine.
# EnrichedResourceRequest : rename methods since we are returning maps now.
Improvement:
# CentralizedOpportunisticContainerAllocator # allocatePerSchedulerKey : Can
you maintain a metrics to avoid iterating through allocations for each
scheduler key
{noformat}
152 for (List<Allocation> allocs : allocations.values()) {
153 totalAllocated += allocs.size();
154 }
{noformat}
was (Author: bibinchundatt):
[~abmodi]
Few minor Nits:
# NodeQueueLoadMonitor following set is not required , already getting set in
constructor
{code}
private int numNodesForAnyAllocation =
DEFAULT_OPP_CONTAINER_ALLOCATION_NODES_NUMBER_USED;
{code}
# EnrichedResourceRequest : rename methods since we are returning maps now.
Improvement:
# CentralizedOpportunisticContainerAllocator # allocatePerSchedulerKey : Can
you maintain a metrics to avoid iterating through allocations for each
scheduler key
{noformat}
152 for (List<Allocation> allocs : allocations.values()) {
153 totalAllocated += allocs.size();
154 }
{noformat}
> Efficient allocation of Opportunistic containers.
> -------------------------------------------------
>
> Key: YARN-9697
> URL: https://issues.apache.org/jira/browse/YARN-9697
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Abhishek Modi
> Assignee: Abhishek Modi
> Priority: Major
> Attachments: YARN-9697.001.patch, YARN-9697.002.patch,
> YARN-9697.003.patch, YARN-9697.004.patch, YARN-9697.005.patch,
> YARN-9697.006.patch, YARN-9697.007.patch, YARN-9697.008.patch,
> YARN-9697.ut.patch, YARN-9697.ut2.patch, YARN-9697.wip1.patch,
> YARN-9697.wip2.patch
>
>
> In the current implementation, opportunistic containers are allocated based
> on the number of queued opportunistic container information received in node
> heartbeat. This information becomes stale as soon as more opportunistic
> containers are allocated on that node.
> Allocation of opportunistic containers happens on the same heartbeat in which
> AM asks for the containers. When multiple applications request for
> Opportunistic containers, containers might get allocated on the same set of
> nodes as already allocated containers on the node are not considered while
> serving requests from different applications. This can lead to uneven
> allocation of Opportunistic containers across the cluster leading to
> increased queuing time
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
