[
https://issues.apache.org/jira/browse/YARN-9052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16973269#comment-16973269
]
Szilard Nemeth commented on YARN-9052:
--------------------------------------
So as of now, we have a successful run for [^YARN-9052.testlogs.002.patch] but
I was not able to extract the logs of all testcases from Jenkins so I was not
able to grep for my messages :(
Local test executes forever and fails at various points.
Right now, my strategy is: If I throw an exception in
org.apache.hadoop.yarn.server.resourcemanager.MockRM#submitApp([22 parameters
ommitted]), and include the text I wanted to log, I can see the parameter
values. So, in overall:
1. Run jenkins with the log patch, throwing exceptions to capture the parameter
values of submitApp.
2. Run jenkins with the modified code and see which testcases fail
3. Run jenkins with the modified code + add the exception logging trick to
compare what is potentially different with run 1. and run 2.
[~adam.antal], [~sunilg]: Does this sound like a good plan?
Thanks!
> Replace all MockRM submit method definitions with a builder
> -----------------------------------------------------------
>
> Key: YARN-9052
> URL: https://issues.apache.org/jira/browse/YARN-9052
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Minor
> Attachments: YARN-9052.001.patch, YARN-9052.002.patch,
> YARN-9052.003.patch, YARN-9052.testlogs.002.patch,
> YARN-9052.testlogs.002.patch, YARN-9052.testlogs.patch
>
>
> MockRM has 31 definitions of submitApp, most of them having more than
> acceptable number of parameters, ranging from 2 to even 22 parameters, which
> makes the code completely unreadable.
> On top of unreadability, it's very hard to follow what RmApp will be produced
> for tests as they often pass a lot of empty / null values as parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
