[
https://issues.apache.org/jira/browse/YARN-9958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974079#comment-16974079
]
Tao Yang commented on YARN-9958:
--------------------------------
Thanks [~jiwq] for this improvement. Patch LGTM, the related r/w lock only work
for ContainerExecutor#pidFiles which is a concurrent hash map and no need to be
guaranteed by additional lock.
I will commit this a few days later if no further comments.
> Remove the invalid lock in ContainerExecutor
> --------------------------------------------
>
> Key: YARN-9958
> URL: https://issues.apache.org/jira/browse/YARN-9958
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Wanqiang Ji
> Assignee: Wanqiang Ji
> Priority: Major
>
> ContainerExecutor has ReadLock and WriteLock. These used to call get/put
> method of ConcurrentMap. Due to the ConcurrentMap providing thread safety and
> atomicity guarantees, so we can remove the lock.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
