[
https://issues.apache.org/jira/browse/YARN-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16974747#comment-16974747
]
Jonathan Hung commented on YARN-8842:
-------------------------------------
I've attached [^YARN-8842-branch-2.001.patch]. Main differences are :
* Replacing {{expected}} resource maps with manually constructed ones, e.g:
{{computeExpectedCustomResourceValues(testData.customResourceValues, (k, v) ->
v * containers}} becomes
{noformat}
+ Map<String, Long> expected = new HashMap<>();
+ for (Map.Entry<String, Long> entry :
testData.customResourceValues.entrySet()) {
+ expected.put(entry.getKey(), entry.getValue() * containers);
+ }{noformat}
* Duplicating all of the \{{assertAllMetrics}}, {{assertQueueMetricsOnly}},
{{assertAllQueueMetrics}}, \{{checkAllQueueMetrics}} four times, each one looks
like \{{assertAllXMetrics}}, {{assertQueueXMetricsOnly}},
{{assertAllXQueueMetrics}}, \{{checkAllXQueueMetrics}} where X = \{Pending,
Allocated, Preempted, Reserved}
[~epayne]/[~snemeth] could you help review? Thanks!
> Expose metrics for custom resource types in QueueMetrics
> --------------------------------------------------------
>
> Key: YARN-8842
> URL: https://issues.apache.org/jira/browse/YARN-8842
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Fix For: 3.3.0, 3.2.2, 3.1.4
>
> Attachments: YARN-8842-branch-2.001.patch, YARN-8842.001.patch,
> YARN-8842.002.patch, YARN-8842.003.patch, YARN-8842.004.patch,
> YARN-8842.005.patch, YARN-8842.006.patch, YARN-8842.007.patch,
> YARN-8842.008.patch, YARN-8842.009.patch, YARN-8842.010.patch,
> YARN-8842.011.patch, YARN-8842.012.patch
>
>
> This is the 2nd dependent jira of YARN-8059.
> As updating the metrics is an independent step from handling preemption, this
> jira only deals with the queue metrics update of custom resources.
> The following metrics should be updated:
> * allocated resources
> * available resources
> * pending resources
> * reserved resources
> * aggregate seconds preempted
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
