[
https://issues.apache.org/jira/browse/YARN-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979418#comment-16979418
]
Manikandan R commented on YARN-6492:
------------------------------------
{quote}in pSourceName, how come we split partition by Q_SPLITTER? I think we
don't need to do any splitting here (there should only be one partition){\quote}
Made changes.
{quote}Do we need a separate getPartitionMetrics? Can we track a partition's
metrics via that partition + root queue?{\quote}
Tried to incorporate getPartitionMetrics functionality inside
getPartitionQueueMetrics, then ended up in having many if-else blocks and found
that it is not clean and elegant. At the same time, having single method can
reduce changes on the collar side. Had a different approach to have
getPartitionQueueMetrics inside PartitionQueueMetrics class like getUserMetrics
which can take care of the same functionality but in much better organised
fashion. So based on the metrics object, appropriate method would be called at
runtime as methods are overridden. Found this later approach better when
compared to earlier approach. Have incorporated this change as well in
.007.WIP.patch. Thoughts?
{quote}For setAvailableResourcesToUser - how come we add this bit?{\quote}
In addition to earlier comment, Yes, it is not correct behaviour and same has
been addressed in YARN-9767 WIP patch.
> Generate queue metrics for each partition
> -----------------------------------------
>
> Key: YARN-6492
> URL: https://issues.apache.org/jira/browse/YARN-6492
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacity scheduler
> Reporter: Jonathan Hung
> Assignee: Manikandan R
> Priority: Major
> Attachments: PartitionQueueMetrics_default_partition.txt,
> PartitionQueueMetrics_x_partition.txt, PartitionQueueMetrics_y_partition.txt,
> YARN-6492.001.patch, YARN-6492.002.patch, YARN-6492.003.patch,
> YARN-6492.004.patch, YARN-6492.005.WIP.patch, YARN-6492.006.WIP.patch,
> YARN-6492.007.WIP.patch, partition_metrics.txt
>
>
> We are interested in having queue metrics for all partitions. Right now each
> queue has one QueueMetrics object which captures metrics either in default
> partition or across all partitions. (After YARN-6467 it will be in default
> partition)
> But having the partition metrics would be very useful.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
