[ 
https://issues.apache.org/jira/browse/YARN-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982003#comment-16982003
 ] 

Eric Badger commented on YARN-9561:
-----------------------------------

Attaching patch 015 that removes the dependency on libhadoop and adds the 
source files directly into the compilation in CMakeLists.txt. I'm not sure that 
this is the correct solution, but it does solve the issue. that was seen in 
YARN-9988. 

Thanks to [~Jim_Brennan] for finding this solution and testing it out. 

{noformat}
ebadger@C02XG1MYJGH8: diff ~/patches/YARN-9561.014.patch 
~/patches/YARN-9561.015.patch
33c33
< index 7e8b19f3e66..92e17976e72 100644
---
> index 7e8b19f3e66..677429bb99c 100644
36c36
< @@ -16,7 +16,8 @@
---
> @@ -16,12 +16,15 @@
46c46,53
< @@ -115,6 +116,7 @@ include_directories(
---
>  set(GTEST_SRC_DIR 
> ${CMAKE_SOURCE_DIR}/../../../../../hadoop-common-project/hadoop-common/src/main/native/gtest)
>
> +set(HADOOP_COMMON_SEC_PATH 
> ${HADOOP_COMMON_PATH}/src/main/native/src/org/apache/hadoop/security)
> +
>  # determine if container-executor.conf.dir is an absolute
>  # path in case the OS we're compiling on doesn't have
>  # a hook in get_executable. We'll use this define
> @@ -115,6 +118,7 @@ include_directories(
50c57
< +    ${HADOOP_COMMON_PATH}/src/main/native/src/org/apache/hadoop/security
---
> +    ${HADOOP_COMMON_SEC_PATH}
54c61
< @@ -129,6 +131,7 @@ add_library(container
---
> @@ -129,6 +133,7 @@ add_library(container
62c69
< @@ -138,6 +141,12 @@ add_library(container
---
> @@ -138,6 +143,14 @@ add_library(container
71a79,80
> +    ${HADOOP_COMMON_SEC_PATH}/hadoop_user_info.c
> +    ${HADOOP_COMMON_SEC_PATH}/hadoop_group_info.c
75c84
< @@ -146,6 +155,8 @@ add_executable(container-executor
---
> @@ -146,6 +159,7 @@ add_executable(container-executor
79d87
< +    ${HADOOP_COMMON_PATH}/target/native/target/usr/local/lib/libhadoop.a
84c92
< @@ -155,7 +166,10 @@ add_executable(test-container-executor
---
> @@ -155,7 +169,9 @@ add_executable(test-container-executor
91d98
< +    ${HADOOP_COMMON_PATH}/target/native/target/usr/local/lib/libhadoop.a
96c103
< @@ -173,8 +187,16 @@ add_executable(cetest
---
> @@ -173,8 +189,15 @@ add_executable(cetest
108d114
< +        ${HADOOP_COMMON_PATH}/target/native/target/usr/local/lib/libhadoop.a
{noformat}

> Add C changes for the new RuncContainerRuntime
> ----------------------------------------------
>
>                 Key: YARN-9561
>                 URL: https://issues.apache.org/jira/browse/YARN-9561
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>            Priority: Major
>             Fix For: 3.3.0
>
>         Attachments: YARN-9561.001.patch, YARN-9561.002.patch, 
> YARN-9561.003.patch, YARN-9561.004.patch, YARN-9561.005.patch, 
> YARN-9561.006.patch, YARN-9561.007.patch, YARN-9561.008.patch, 
> YARN-9561.009.patch, YARN-9561.010.patch, YARN-9561.011.patch, 
> YARN-9561.012.patch, YARN-9561.013.patch, YARN-9561.014.patch, 
> YARN-9561.015.patch
>
>
> This JIRA will be used to add the C changes to the container-executor native 
> binary that are necessary for the new RuncContainerRuntime. There should be 
> no changes to existing code paths. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to