[
https://issues.apache.org/jira/browse/YARN-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982475#comment-16982475
]
Gergely Pollak edited comment on YARN-9444 at 11/26/19 2:01 PM:
----------------------------------------------------------------
Thanks [~adam.antal] for the feedback, I've extracted the "(yarn.io/)?" part
into a constant, but since the whole regexp is relying on the external
argument, I cannot extract the whole regexp to a constant and I think
extracting the "[^.]+$" part wouldn't help much.
was (Author: shuzirra):
Thanks [~adam.antal] for the feedback, I've extracted the "(yarn.io/)?" part
into a constant, but since the while regexp is relying on the external
argument, I cannot extract the whole regexp to a constant and I think
extracting the "[^.]+$" part wouldn't help much.
> YARN API ResourceUtils's getRequestedResourcesFromConfig doesn't recognize
> yarn.io/gpu as a valid resource
> ----------------------------------------------------------------------------------------------------------
>
> Key: YARN-9444
> URL: https://issues.apache.org/jira/browse/YARN-9444
> Project: Hadoop YARN
> Issue Type: Bug
> Components: api
> Reporter: Gergely Pollak
> Assignee: Gergely Pollak
> Priority: Minor
> Attachments: YARN-9444.001.patch, YARN-9444.002.patch,
> YARN-9444.003.patch
>
>
> The original issue was the jobclient test did not send the requested resource
> type, when specified in the command line eg:
> {code:java}
> hadoop jar hadoop-mapreduce-client-jobclient-tests.jar sleep
> -Dmapreduce.reduce.resource.yarn.io/gpu=1 -m 10 -r 1 -mt 90000
> {code}
> After some investigation, it turned out it only affects resource types with
> name containing '.' characters. And the root cause is regexp from the
> getRequestedResourcesFromConfig method.
> {code:java}
> "^" + Pattern.quote(prefix) + "[^.]+$"
> {code}
> This regexp explicitly forbids any dots in the resource type name, which is
> inconsistent with the default resource type for gpu and fpga, which are
> yarn.io/gpu and yarn.io/fpga respectively.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
