[ 
https://issues.apache.org/jira/browse/YARN-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983483#comment-16983483
 ] 

Peter Bacsko commented on YARN-9866:
------------------------------------

[[email protected]] just one thing: in the testcase, you don't invoke 
{{mockRM.close();}}. Another problem is that if you call this after the 
assertion, then the mock RM will not be closed. This is a problem in other 
tests as well. Best would be to use a try-catch block and update the remaining 
tests like:
{noformat}
MockRM mockRM = null;
try {
  .. test logic
} finally {
  if (mockRM != null) {
    mockRM.close();
  }
}
{noformat}
Could you do this update in this patch?

> u:user2:%primary_group is not working as expected
> -------------------------------------------------
>
>                 Key: YARN-9866
>                 URL: https://issues.apache.org/jira/browse/YARN-9866
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Manikandan R
>            Assignee: Manikandan R
>            Priority: Major
>         Attachments: YARN-9866.001.patch, YARN-9866.002.patch
>
>
> Please refer #1 in 
> https://issues.apache.org/jira/browse/YARN-9841?focusedCommentId=16937024&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16937024
>  for more details



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to