[
https://issues.apache.org/jira/browse/YARN-9938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983493#comment-16983493
]
Peter Bacsko commented on YARN-9938:
------------------------------------
[[email protected]] looks good at first sight. Two comments:
# {{IOException}} is thrown if the validation fails. I believe
{{YarnException}} is much more preferable in this situation.
# Is it possible to test the negative codepath? Maybe not all cases, but 1-2
test would be useful.
> Validate Parent Queue for QueueMapping contains dynamic group as parent queue
> -----------------------------------------------------------------------------
>
> Key: YARN-9938
> URL: https://issues.apache.org/jira/browse/YARN-9938
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Manikandan R
> Assignee: Manikandan R
> Priority: Major
> Attachments: YARN-9938.001.patch, YARN-9938.002.patch,
> YARN-9938.003.patch
>
>
> Currently \{{UserGroupMappingPlacementRule#validateParentQueue}} validates
> the parent queue using queue path. With dynamic group using %primary_group
> and %secondary_group in place (Refer YARN-9841 and YARN-9865) , parent queue
> validation should also happen for these above 2 queue mappings after
> resolving the above wildcard pattern to corresponding groups at runtime.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
