[
https://issues.apache.org/jira/browse/YARN-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984188#comment-16984188
]
Yongjun Zhang edited comment on YARN-5939 at 11/28/19 7:17 AM:
---------------------------------------------------------------
HI [~lxw668899], [~cheersyang] and [~bibinchundatt],
Thank you guys for the work here.
I have a question, this issue was created at 29/Nov/16 01:05, while YARN-58 was
fixed at 20/Aug/12 11:33 (there is a 4+ years gap!). And it was concluded that
YARN-58 should be the fix. Wonder if the version [~lxw668899] reported the
issue about already had the fix of YARN-58? Sounds the answer should be Yes
given "2.5.1, 2.7.3" are said to be the impacted version.
Based on the comment below made by [~lxw668899]:
https://issues.apache.org/jira/browse/YARN-5939?focusedCommentId=15750463&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15750463
the patch provided in this jira seem to have helped. Wonder if we missed
something here?
Thanks.
was (Author: yzhangal):
HI [~lxw668899], [~cheersyang] and [~bibinchundatt],
Thank you guys for the work here.
I have a question, this issue was created at 29/Nov/16 01:05, while YARN-58 was
fixed at 20/Aug/12 11:33 (there is a 4+ years gap!). And it was concluded that
YARN-58 should be the fix. Wonder if the version [~lxw668899] reported the
issue about already had the fix of YARN-58?
Based on the comment below made by [~lxw668899]:
https://issues.apache.org/jira/browse/YARN-5939?focusedCommentId=15750463&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15750463
the patch provided in this jira seem to have helped. Wonder if we missed
something here?
Thanks.
> FSDownload leaks FileSystem resources
> -------------------------------------
>
> Key: YARN-5939
> URL: https://issues.apache.org/jira/browse/YARN-5939
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.5.1, 2.7.3
> Reporter: liuxiangwei
> Assignee: Weiwei Yang
> Priority: Major
> Labels: leak
> Attachments: YARN-5939.004.patch, YARN-5939.005.patch,
> YARN-5939.01.patch, YARN-5939.02.patch, YARN-5939.03.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Background
> To use our self-defined FileSystem class, the item of configuration
> "fs.%s.impl.disable.cache" should set to true.
> In YARN's source code, the class named
> "org.apache.hadoop.yarn.util.FSDownload" use getFileSystem but never close,
> which leading to file descriptor leak because our self-defined FileSystem
> class close the file descriptor when the close function is invoked.
> My Question below:
> 1. whether invoking "getFileSystem" but never close is YARN's expected
> behavior
> 2. what should we do in our self-defined FileSystem resolve it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
