[
https://issues.apache.org/jira/browse/YARN-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999423#comment-16999423
]
Szilard Nemeth edited comment on YARN-10035 at 12/18/19 6:45 PM:
-----------------------------------------------------------------
Hi [~adam.antal]!
Thanks for this patch.
In WebServices.getApps, you added an if:
{code:java}
if (nameQuery != null && nameQuery.equals(appReport.getName())) {
continue;
}
{code}
Shouldn't the second part of the statement be? :
{code:java}
!nameQuery.equals(appReport.getName())
{code}
Actually, you are executing the continue statement if the app name in the query
matches the name from the appReport, so apps with provided name are skipped.
Am I misunderstanding something?
Otherwise, the patch looks good.
was (Author: snemeth):
Hi [~adam.antal]!
Thanks for this patch.
In WebServices.getApps, you added an if:
{code:java}
if (nameQuery != null && nameQuery.equals(appReport.getName())) {
continue;
}
{code}
Shouldn't the second part of the statement be? :
{code:java}
!nameQuery.equals(appReport.getName())
{code}
Actually, you are executing the continue statement if the app name in the query
matches the name from the appReport, so apps with provided name are skipped.
Am I misunderstanding something?
Otherwise, the patch looks good.
> Add ability to filter the Cluster Applications API request by name
> ------------------------------------------------------------------
>
> Key: YARN-10035
> URL: https://issues.apache.org/jira/browse/YARN-10035
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn
> Affects Versions: 3.3.0
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
> Attachments: YARN-10035.001.patch, YARN-10035.002.patch
>
>
> According to the
> [documentation|https://hadoop.apache.org/docs/r3.2.0/hadoop-yarn/hadoop-yarn-site/ResourceManagerRest.html]
> we don't support filtering by name in the Cluster Applications API request.
> Usually application tags are a perfect way for tracking applications, but for
> MR applications the older CLIs usually doesn't support providing app tags,
> while specifying the name of the job is possible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
