[
https://issues.apache.org/jira/browse/YARN-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012165#comment-17012165
]
Szilard Nemeth commented on YARN-10067:
---------------------------------------
Hi [~pbacsko]!
Thanks for fixing the concerns I raised.
Patch looks good now.
Regarding what I've mentioned in my previous comment with bullet point 5, I
uploaded a patch based on your latest patch, so you can check what I was meant.
You can probably adjust the namings here and there but I think you will get the
basic idea: No scattered dryRun checks everywhere in the code, all of them are
handled in a single point, ConversionOptions. Also, if we ever want to have
more conversion options like dry run, we can add it more easily.
Please share your thoughts.
Thanks.
> Add dry-run feature to FS-CS converter tool
> -------------------------------------------
>
> Key: YARN-10067
> URL: https://issues.apache.org/jira/browse/YARN-10067
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
> Attachments: YARN-10067-001.patch, YARN-10067-002.patch,
> YARN-10067-003.patch, YARN-10067-004.patch, YARN-10067-005.patch
>
>
> Add a "d" / "-dry-run" switch to the tool. The purpose of this would be to
> inform the user whether a conversion is possible and if it is, are there any
> warnings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
