[
https://issues.apache.org/jira/browse/YARN-10019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013283#comment-17013283
]
Hudson commented on YARN-10019:
-------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17850 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/17850/])
YARN-10019. Improved container-executor exec() calls. (eyang: rev
2301b25899b5ae293719f4b4dcb8584c20a36bd5)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/util.h
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/runc/runc.c
> container-executor: misc improvements in child processes and exec() calls
> -------------------------------------------------------------------------
>
> Key: YARN-10019
> URL: https://issues.apache.org/jira/browse/YARN-10019
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Minor
> Fix For: 3.3.0
>
> Attachments: YARN-10019-001.patch, YARN-10019-002.patch
>
>
> There are a couple of improvements that we can do in container-executor
> regarding how we exit from child processes and how we handle failed exec()
> calls:
> 1. If we're in the child code path and we detect an erroneous condition, the
> usual way is just simply call {{_exit()}}. Normal {{exit()}} occurs in the
> parent. Calling {{_exit()}} prevents flushing stdio buffers twice and any
> cleanup logic registered with {{atexit()}} or {{on_exit()}} will run only
> once.
> 2. There's code like {{if (execlp(script_file_dest, script_file_dest, NULL)
> != 0) ...}} which is not necessary. Exec functions are not supposed to
> return. If they do, it's definitely an error, so no need to check the return
> value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
