[ https://issues.apache.org/jira/browse/YARN-10022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015922#comment-17015922 ]
Kinga Marton commented on YARN-10022: ------------------------------------- The attached patch is a Work in progress one, because I have to cover the changes with some test cases, and also I expect to have some checkstyle issues and some failing tests. Some comments related to the patch: * we need an API to decide whether a capacity scheduler configuration change is valid or not ad return the new merged configuration if it is a valid one. * my first idea was to extract all the verification steps fro the actual code and write a clear verification part. Unfortunately I couldn't extract all the steps, so at one point I need to create a new instance of CS and call reinitialise queues to be sure that all the validation steps are done. For this part I will open a follow up Jira to try to extract that part as well and remove that hacky part. * I have added a test file, what contains only the signature of the test cases I want to implement, any other test case ideas are very welcomed. :) > Create RM Rest API to validate a CapacityScheduler Configuration > ---------------------------------------------------------------- > > Key: YARN-10022 > URL: https://issues.apache.org/jira/browse/YARN-10022 > Project: Hadoop YARN > Issue Type: New Feature > Reporter: Kinga Marton > Assignee: Kinga Marton > Priority: Major > Attachments: YARN-10022.WIP.patch > > > RMWebService should expose a new api which gets a CapacityScheduler > Configuration as an input, validates it and returns success / failure. > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org