[ https://issues.apache.org/jira/browse/YARN-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017044#comment-17017044 ]
Szilard Nemeth commented on YARN-10083: --------------------------------------- Hi [~adam.antal], This is a great finding. One thing I found: org.apache.hadoop.yarn.logaggregation.LogToolUtils#getResponeFromNMWebService has a typo in its name. I wanted to quickly fix it and then let it go, but found another occurrences of "getResponeFromNMWebService" in the codebase. Could you please check those as well? Thanks. > Provide utility to ask whether an application is in final status > ---------------------------------------------------------------- > > Key: YARN-10083 > URL: https://issues.apache.org/jira/browse/YARN-10083 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Adam Antal > Assignee: Adam Antal > Priority: Minor > Attachments: YARN-10083.001.patch, YARN-10083.002.patch, > YARN-10083.002.patch, YARN-10083.branch-3.2.001.patch > > > This code part is severely duplicated across the Hadoop repo: > {code:java} > public static boolean isApplicationFinalState(YarnApplicationState > appState) { > return appState == YarnApplicationState.FINISHED > || appState == YarnApplicationState.FAILED > || appState == YarnApplicationState.KILLED; > } > {code} > This functionality is used heavily by the log aggregation as well, so we may > do some sanitizing here. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org