[
https://issues.apache.org/jira/browse/YARN-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020141#comment-17020141
]
Peter Bacsko commented on YARN-10085:
-------------------------------------
Thanks for the comments [~adam.antal].
_"Could you please give some explanation why we have to explicitly set the
resource calculator class in FSYarnSiteConverter#convertSiteProperties?"_
I looked into CS initialization and it uses {{DefaultResourceCalculator}} as
default, so I removed the else branch.
_"As a minor nit, I'd add a simple optimization in
FSConfigToCSConfigConverter#isDrfUsed:"_
Changed the order of calls. However, I didn't want to touch the recursive
check, don't think it's not worth doing it (walking a tree even with 3000 nodes
sould take microseconds).
> FS-CS converter: remove mixed ordering policy check
> ---------------------------------------------------
>
> Key: YARN-10085
> URL: https://issues.apache.org/jira/browse/YARN-10085
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Critical
> Attachments: YARN-10085-001.patch, YARN-10085-002.patch,
> YARN-10085-003.patch
>
>
> In the converter, this part is very strict and probably unnecessary:
> {noformat}
> // Validate ordering policy
> if (queueConverter.isDrfPolicyUsedOnQueueLevel()) {
> if (queueConverter.isFifoOrFairSharePolicyUsed()) {
> throw new ConversionException(
> "DRF ordering policy cannot be used together with fifo/fair");
> } else {
> capacitySchedulerConfig.set(
> CapacitySchedulerConfiguration.RESOURCE_CALCULATOR_CLASS,
> DominantResourceCalculator.class.getCanonicalName());
> }
> }
> {noformat}
> It's also misleading, because Fair policy can be used under DRF, so the error
> message is incorrect.
> Let's remove these checks and rewrite the converter in a way that it
> generates a valid config even if fair/drf is somehow mixed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
