[
https://issues.apache.org/jira/browse/YARN-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813560#comment-13813560
]
Omkar Vinit Joshi commented on YARN-674:
----------------------------------------
Thanks [~vinodkv] for review...
bq. Does this patch also include YARN-1210? Seems like it, we should separate
that code.
No .. anything specific? YARN-1210 is more about waiting for older AM to finish
before launching a new AM.
bq. Depending on the final patch, I think we should split
RMAppManager.submitApp into two, one for regular submit and one for submit
after recovery.
Splitting the method into 2.
* submitApplication - normal application submission
* submitRecoveredApplication - submitting recovered application
bq. RMAppState.java change is unnecessary.
fixed
bq. ForwardingEventHandler is a bottleneck for renewals now - especially during
submission. We need to have a thread pool.
Create fixed thread pool service with thread count controllable via
configuration (Not adding this to yarn-default). Keeping default thread count
to be 5. fair enough?
bq. Once we do the above, the old concurrency test should be added back.
yeah..added that test back..
bq. We are undoing most of YARN-1107. Good that we laid the groundwork there.
Let's make sure we remove all the dead code. One comment stands out
Anything did I miss here? didn't understand. The comment I have not removed as
it is still valid.
bq. The newly added test can have race conditions? We may be lucky in the test,
but in real life scenario, client has to submit app and poll for app failure
due to invalid tokens
I think it will not. For clients yes after they submit the application they
will have to keep polling to know the status of the application (got accepted
or failed due to token renewal).
bq. Similarly we should add a test for successful submission after renewal.
sure added one.. checking for RMAppEvent.START
> Slow or failing DelegationToken renewals on submission itself make RM
> unavailable
> ---------------------------------------------------------------------------------
>
> Key: YARN-674
> URL: https://issues.apache.org/jira/browse/YARN-674
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Omkar Vinit Joshi
> Attachments: YARN-674.1.patch, YARN-674.2.patch, YARN-674.3.patch,
> YARN-674.4.patch
>
>
> This was caused by YARN-280. A slow or a down NameNode for will make it look
> like RM is unavailable as it may run out of RPC handlers due to blocked
> client submissions.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
