[ 
https://issues.apache.org/jira/browse/YARN-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813735#comment-13813735
 ] 

Bikas Saha commented on YARN-1197:
----------------------------------

Can we do with just change_succeeded and change_failed lists instead of 4 
lists. Using the containerId, the AM can determine which one was 
increase/decrease.
{noformat}
+message        ChangeContainersResourceResponseProto   {       
+               repeated        ContainerIdProto        
succeed_increased_containers    =       1;      
+               repeated        ContainerIdProto        
succeed_decreased_containers    =       2;      
+               repeated        ContainerIdProto        
failed_increased_containers     =       3;      
+               repeated        ContainerIdProto        
failed_decreased_containers     =       4;              
+}
{noformat}

I dont think its correct for ResourceRequest to be used to increase resources 
for an allocated container. I was expecting a new optional repeated field of 
type ResourceChangeContextProto in AllocateRequest. For requesting increase in 
container C's resource, the AM will add a ResourceChangeContextProto for that 
container in the next AllocateRequest. 

In AllocateResponse, the type of increased container should be 
ResourceIncreaseContextProto, right? Without that the AM cannot get the new 
container token for that container.

The NM changes also need to handle enforcing the new resource via cgroups etc 
in addition to changing the monitoring. This needs to be clarified in the 
document.

> Support changing resources of an allocated container
> ----------------------------------------------------
>
>                 Key: YARN-1197
>                 URL: https://issues.apache.org/jira/browse/YARN-1197
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: api, nodemanager, resourcemanager
>    Affects Versions: 2.1.0-beta
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: yarn-1197-v2.pdf, yarn-1197-v3.pdf, yarn-1197.pdf
>
>
> Currently, YARN cannot support merge several containers in one node to a big 
> container, which can make us incrementally ask resources, merge them to a 
> bigger one, and launch our processes. The user scenario is described in the 
> comments.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to