[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046840#comment-17046840 ]
Manikandan R commented on YARN-9831: ------------------------------------ [~BilwaST] Thanks for the patch. Had a quick glance. Locks has been changed from "write" to "read" in {{createAndGetNMToken}} method assuming there shouldn't be any issues while adding Node Id's into Set ( nodeSet.add(container.getNodeId()); ) because it has been created ConcurrentHashMap.newKeySet(). If this is true, Should we apply the same principle to other places where in Node gets removed ( removeNodeKey() ) ? > NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService > allocate flow > ------------------------------------------------------------------------------------ > > Key: YARN-9831 > URL: https://issues.apache.org/jira/browse/YARN-9831 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Bibin Chundatt > Assignee: Bilwa S T > Priority: Critical > Attachments: YARN-9831.001.patch, YARN-9831.002.patch > > > Currently attempt's NMToken cannot be generated independently. > Each attempts allocate flow blocks each other. We should improve the same -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org