[
https://issues.apache.org/jira/browse/YARN-10148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046906#comment-17046906
]
Szilard Nemeth commented on YARN-10148:
---------------------------------------
Hi [~kmarton],
Thanks for fixing all of my comments.
Just found 2 things which I have corrected based on our offline discussion:
1. Javadoc of the testcase
org.apache.hadoop.yarn.server.resourcemanager.QueueACLsTestBase#testQueueAclDefaultValues
was misleading:
{code:java}
/**
* Test for the case when no ACLs are defined, so the default values are used
* Expected result: The default ACLs for the root queue is "*"(all) and for
* the other queues are " " (none), so the user will have access to all the
* queues because they will have permissions from the root.
*
* @throws IOException
*/
{code}
Specifically this part:
{code:java}
The default ACLs for the root queue is "*"(none) and for
* the other
{code}
The value "*" means all so I changed "none" to "all".
2. In TestCapacitySchedulerQueueACLs#updateConfigWithDAndD1Queues:
The code that sets ACLs for D and D1 queues is this:
{code:java}
if (queueDAcl != null) {
setAdminAndSubmitACL(csConf, queueDAcl, dPath);
csConf.setAcl(dPath, QueueACL.ADMINISTER_QUEUE, queueDAcl);
csConf.setAcl(dPath, QueueACL.SUBMIT_APPLICATIONS, queueDAcl);
}
if (queueD1Acl != null) {
setAdminAndSubmitACL(csConf, d1Path, queueD1Acl);
csConf.setAcl(d1Path, QueueACL.ADMINISTER_QUEUE, queueD1Acl);
csConf.setAcl(d1Path, QueueACL.SUBMIT_APPLICATIONS, queueD1Acl);
} {code}
Here, you extracted the setAdminAndSubmitACL method. Additional calls to
csConf.setAcl() are left there in both conditions, accidentally so I removed
them.
> Add Unit test for queue ACL for both FS and CS
> ----------------------------------------------
>
> Key: YARN-10148
> URL: https://issues.apache.org/jira/browse/YARN-10148
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
> Reporter: Kinga Marton
> Assignee: Kinga Marton
> Priority: Major
> Attachments: YARN-10148.001.patch, YARN-10148.002.patch,
> YARN-10148.003.patch, YARN-10148.004.patch, YARN-10148.005.patch,
> YARN-10148.006.patch
>
>
> Add some unit tests covering the queue ACL evaluation for both FS and CS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
