[
https://issues.apache.org/jira/browse/YARN-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047727#comment-17047727
]
Gergely Pollak commented on YARN-9879:
--------------------------------------
Latest 2 patches are fixes to get rid of the enormous amount of unit test
failures. Some cleanup for the CSQueueStore are required, since I had to
reintroduce a feature which caused a bug in the current queue management
solution, since too many tests were relying on it.
The tests often times get non leaf queues by their short name, the issue with
this is it is possible to overwrite a leaf queue with a non-leaf queue. Eg if
we have the two following queues:
root.a.leaf
root.b.c.leaf.e
Then the get('leaf') will return the root.b.c.leaf instead of root.a.leaf. Also
in the current implementation it is quite hectic what happens if there is a
non-leaf queue with the same name as a leaf queue. So I thought I would only
allow referencing by short names only to leaf queues, but it won't work.
So here is my proposal:
Leaf queues will have priority, so if there is leaf queue and a non-leaf queue
with the short name, the name will always refer to the leaf queue, if there are
two leaf queues with the same name, none will be accessible. This is not the
best solution but it will fix the bug in the current implementation, and we
keep the possibility to reference non-leaf queues by their short name, and our
tests will be grateful for this.
> Allow multiple leaf queues with the same name in CS
> ---------------------------------------------------
>
> Key: YARN-9879
> URL: https://issues.apache.org/jira/browse/YARN-9879
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gergely Pollak
> Assignee: Gergely Pollak
> Priority: Major
> Labels: fs2cs
> Attachments: CSQueue.getQueueUsage.txt, DesignDoc_v1.pdf,
> YARN-9879.POC001.patch, YARN-9879.POC002.patch, YARN-9879.POC003.patch,
> YARN-9879.POC004.patch, YARN-9879.POC005.patch, YARN-9879.POC006.patch,
> YARN-9879.POC007.patch
>
>
> Currently the leaf queue's name must be unique regardless of its position in
> the queue hierarchy.
> Design doc and first proposal is being made, I'll attach it as soon as it's
> done.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
