[ 
https://issues.apache.org/jira/browse/YARN-10167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051916#comment-17051916
 ] 

Szilard Nemeth commented on YARN-10167:
---------------------------------------

Hi [~pbacsko],
Checked your patch, it looks to me, committed it to trunk.
One additional thing I did with your patch before committing is reformatting 
the XML configs.
I think we need to update the description here, as it seems outdated.
In my view, the reason why you did not use MockRM at all is you started up a 
CapacityScheduler instance (in ConvertedConfigValidator) and validate the 
config in a more "closer way" to production code.

Can you remove / modify the description?
I think this line should be changed: 
{quote}
Also, in the test, we should try to leverage MockRM to validate generated 
configs as much as we could.
{quote}


> FS-CS Converter: Need to validate c-s.xml after converting
> ----------------------------------------------------------
>
>                 Key: YARN-10167
>                 URL: https://issues.apache.org/jira/browse/YARN-10167
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Peter Bacsko
>            Priority: Major
>              Labels: fs2cs, newbie
>         Attachments: YARN-10167-001.patch, YARN-10167-002.patch, 
> YARN-10167-003.patch, YARN-10167-004.patch, YARN-10167-005.patch
>
>
> Currently we just generated c-s.xml, but we didn't validate that. To make 
> sure the c-s.xml is correct after conversion, it's better to initialize the 
> CS scheduler using configs.
> Also, in the test, we should try to leverage MockRM to validate generated 
> configs as much as we could.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to