[
https://issues.apache.org/jira/browse/YARN-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054919#comment-17054919
]
Andras Gyori edited comment on YARN-9997 at 3/9/20, 3:53 PM:
-------------------------------------------------------------
Thank you for your feedback, [~snemeth].
I have addressed all the issues, and reinforced them with additional unit
tests. #logMutation should not overwrite the data when an invalid (non
linked-list) object is queried from Zookeeper logpath. As for the third
concern, receiving a null value as a config version is considered to be an
invalid state and an IllegalStateException is thrown accordingly.
was (Author: gandras):
Thank you for feedback, [~snemeth].
I have addressed all the issues, and reinforced them with additional unit
tests. #logMutation should not overwrite the data when an invalid (non
linked-list) object is queried from Zookeeper logpath. As for the third
concern, receiving a null value as a config version is considered to be an
invalid state and an IllegalStateException is thrown accordingly.
> Code cleanup in ZKConfigurationStore
> ------------------------------------
>
> Key: YARN-9997
> URL: https://issues.apache.org/jira/browse/YARN-9997
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Andras Gyori
> Priority: Minor
> Attachments: YARN-9997.001.patch, YARN-9997.002.patch,
> YARN-9997.003.patch, YARN-9997.004.patch
>
>
> Many thins can be improved:
> * znodeParentPath could be a local variable
> * zkManager could be private, VisibleForTesting annotation is not needed
> anymore
> * Do something with unchecked casts
> * zkManager.safeSetData calls are almost having the same set of parameters:
> Simplify this
> * Extract zkManager calls to their own methods: They are repeated
> * Remove TODOs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
