[
https://issues.apache.org/jira/browse/YARN-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055161#comment-17055161
]
Benjamin Teke commented on YARN-10002:
--------------------------------------
Thanks for the review [~adam.antal]!
Updated the patch with your suggestions it looks cleaner now.
> Code cleanup and improvements ConfigurationStoreBaseTest
> --------------------------------------------------------
>
> Key: YARN-10002
> URL: https://issues.apache.org/jira/browse/YARN-10002
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Benjamin Teke
> Priority: Minor
> Attachments: YARN-10002.001.patch, YARN-10002.002.patch,
> YARN-10002.003.patch, YARN-10002.004.patch, YARN-10002.005.patch,
> YARN-10002.006.patch
>
>
> * Some protected fields could be package-private
> * Could add a helper method that prepares a simple LogMutation with 1, 2 or 3
> updates (Key + value) as this pattern is used extensively in subclasses
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
