[
https://issues.apache.org/jira/browse/YARN-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057836#comment-17057836
]
Szilard Nemeth commented on YARN-9997:
--------------------------------------
Hi [~gandras],
Patch LGTM, committed to trunk.
For reference, I fixed 2 things before committing:
1. ZKConfigurationStore#getConfigVersion:
There were missing spaces in the log message. Added 2 spaces to the end of both
strings in the sentence.
{code:java}
if (version == null) {
throw new IllegalStateException("Config version can not be properly" +
" serialized. Check Zookeeper config version path to locate" +
" the error!");
}
{code}
2. ZKConfigurationStore#createNewZkPath: Javadoc had a typo on "Zookeeper".
> Code cleanup in ZKConfigurationStore
> ------------------------------------
>
> Key: YARN-9997
> URL: https://issues.apache.org/jira/browse/YARN-9997
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Andras Gyori
> Priority: Minor
> Attachments: YARN-9997.001.patch, YARN-9997.002.patch,
> YARN-9997.003.patch, YARN-9997.004.patch, YARN-9997.005.patch,
> YARN-9997.006.patch
>
>
> Many thins can be improved:
> * znodeParentPath could be a local variable
> * zkManager could be private, VisibleForTesting annotation is not needed
> anymore
> * Do something with unchecked casts
> * zkManager.safeSetData calls are almost having the same set of parameters:
> Simplify this
> * Extract zkManager calls to their own methods: They are repeated
> * Remove TODOs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
