[
https://issues.apache.org/jira/browse/YARN-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058755#comment-17058755
]
Benjamin Teke commented on YARN-9998:
-------------------------------------
Hi [~adam.antal]!
Thanks for the review, I uploaded a new patch based on your comments. Regarding
the last part, in YARN-10189 I proposed a solution which fixes the not closed
Timer problem.
> Code cleanup in LeveldbConfigurationStore
> -----------------------------------------
>
> Key: YARN-9998
> URL: https://issues.apache.org/jira/browse/YARN-9998
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Benjamin Teke
> Priority: Minor
> Attachments: YARN-9998.001.patch, YARN-9998.002.patch
>
>
> Many things can be improved:
> * Field compactionTimer could be a local variable
> * Field versiondb should be camelcase
> * initDatabase is a very long method: Initialize db / versionDb should be in
> separate methods, split this method into smaller chunks
> * Remove TODOs
> * Remove duplicated code block in
> LeveldbConfigurationStore.CompactionTimerTask
> * Any other cleanup
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
