[
https://issues.apache.org/jira/browse/YARN-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815501#comment-13815501
]
Mayank Bansal commented on YARN-955:
------------------------------------
bq. Not necessary. The default value can be read from yarn-default.xml. The
problem is that you can not specify the prefix variables like that in the xml
file. This default URI will be a relative path based on the current directory.
Done
bq. Maybe just call it AHS_ADDRESS
Done
bq. The nested class is not necessary. ApplicationHistoryClientService can
implement ApplicationHistoryProtocol directly.
I think its more cleaner then having service implements the protocol by this
you can pass around protocol handler around
and your service in the future can handle multiplt protocols
bq. Not necessary wrap-up. Please place the simple statement directly in the
callers. Same for getApplications.
Done
bq.Personally, I think returning empty collections is fine to indicate no
results. Otherwise, the caller needs always to check not null first.
Done
bq.Why do you want two references pointing to the same object?
Done
bq. 7. In the original design, we said we're going to make AHS a service of RM,
though it should be independent enough. In this patch, I can see AHS is going
to be an completely independent process. So far, it should be OK, because AHS
needs nothing from RM. However, I'm expecting some more security work to do if
AHS is separate process, as AHS and RM will not share the common context, and
may be launched by different users. Vinod Kumar Vavilapalli, do you have any
opinion about service or process?
I think we are having same discussion in YARN-1266, lets continue there.
bq.Anyway, if we decide to make AHS a process now, this patch should also
include the shell script to launch AHS.
YARN-1242 caters that.
Thanks,
Mayank
> [YARN-321] Implementation of ApplicationHistoryProtocol
> -------------------------------------------------------
>
> Key: YARN-955
> URL: https://issues.apache.org/jira/browse/YARN-955
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Mayank Bansal
> Attachments: YARN-955-1.patch, YARN-955-2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
