[ 
https://issues.apache.org/jira/browse/YARN-10198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17060683#comment-17060683
 ] 

Akhil PB edited comment on YARN-10198 at 3/17/20, 7:29 AM:
-----------------------------------------------------------

Expected behavior:

# *[managedParent].%primary_group*
** Should not create queue named *%primary_group* under *[managedParent]* if 
leaf queue named *%primary_group* already exists.
** Should create new child queue under *[managedParent]* if leaf queue named 
*%primary_group* does not exists.
# *[managedParent].%secondary_group*
** Should not create queue named *%secondary_group* under *[managedParent]* if 
leaf queue named *%secondary_group* already exists.
** Should create new child queue under *[managedParent]* if leaf queue named 
*%secondary_group* does not exists.


Note that for current static mappings like *u:%user:%primary_group* and 
*u:%user:%secondary_group*, following is the behavior and works as expected.

# *u:%user:%primary_group*
** App submitted when leaf queue named *%primary_group* is present
** App failed when leaf queue named *%primary_group* is not present or stopped
# *u:%user:%secondary_group*
** App submitted when leaf queue named *%secondary_group* is present
** App submitted to "default" queue when leaf queue named *%secondary_group* is 
not present

Please share your thoughts if I am missing something.

cc: [~sunilg] [~prabhujoseph] [~pbacsko]


was (Author: akhilpb):
Expected behavior:

# *[managedParent].%primary_group*
** Should not create queue named *%primary_group* under *[managedParent]* if 
leaf queue named *%primary_group* already exists.
** Should create new child queue under *[managedParent]* if leaf queue named 
*%primary_group* does not exists.
# *[managedParent].%secondary_group*
** Should not create queue named *%secondary_group* under *[managedParent]* if 
leaf queue named *%secondary_group* already exists.
** Should create new child queue under *[managedParent]* if leaf queue named 
*%secondary_group* does not exists.


Note that for current static mappings like *u:%user:%primary_group* and 
*u:%user:%secondary_group*, following is the behavior and works as expected.

# *u:%user:%primary_group*
** App submitted when leaf queue named *%primary_group*( is present
** App failed when leaf queue named *%primary_group* is not present or stopped
# *u:%user:%secondary_group*
** App submitted when leaf queue named *%secondary_group* is present
** App submitted to "default" queue when leaf queue named *%secondary_group* is 
not present

Please share your thoughts if I am missing something.

cc: [~sunilg] [~prabhujoseph] [~pbacsko]

> [managedParent].%primary_group mapping rule doesn't work after YARN-9868
> ------------------------------------------------------------------------
>
>                 Key: YARN-10198
>                 URL: https://issues.apache.org/jira/browse/YARN-10198
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacity scheduler
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>
> YARN-9868 introduced an unnecessary check if we have the following placement 
> rule:
> [managedParentQueue].%primary_group
> Here, {{%primary_group}} is expected to be created if it doesn't exist. 
> However, there is this validation code which is not necessary:
> {noformat}
>           } else if (mapping.getQueue().equals(PRIMARY_GROUP_MAPPING)) {
>             if (this.queueManager
>                 .getQueue(groups.getGroups(user).get(0)) != null) {
>               return getPlacementContext(mapping,
>                   groups.getGroups(user).get(0));
>             } else {
>               return null;
>             }
> {noformat}
> We should revert this part to the original version:
> {noformat}
>           } else if (mapping.queue.equals(PRIMARY_GROUP_MAPPING)) {
>             return getPlacementContext(mapping, 
> groups.getGroups(user).get(0));
>         }
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to