[
https://issues.apache.org/jira/browse/YARN-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816232#comment-13816232
]
Ravi Prakash commented on YARN-90:
----------------------------------
Thanks for updating the patch Song! With almost the same changes as nigel, I
was able to get the originally invalid directories to be used again. So the
src/main code looks good to me. The one nit I had was that
{code} } catch (IOException e2) {
Assert.fail("should not throw an exception");
Shell.execCommand(Shell.getSetPermissionCommand("755", false,
testDir.getAbsolutePath()));
throw e2;
} {code}, {code} catch (InterruptedException e1) {
} {code} , {code} } catch (IOException e2) {
Assert.fail("should not throw an exception");
throw e2;
} {code} and {code} } catch (IOException e) {
Assert.fail("Service should have thrown an exception while closing");
throw e;
} {code} can simply be removed.
Other than that, the patch looks good to me. +1. Thanks a lot Nigel and Song!
> NodeManager should identify failed disks becoming good back again
> -----------------------------------------------------------------
>
> Key: YARN-90
> URL: https://issues.apache.org/jira/browse/YARN-90
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Ravi Gummadi
> Attachments: YARN-90.1.patch, YARN-90.patch, YARN-90.patch,
> YARN-90.patch
>
>
> MAPREDUCE-3121 makes NodeManager identify disk failures. But once a disk goes
> down, it is marked as failed forever. To reuse that disk (after it becomes
> good), NodeManager needs restart. This JIRA is to improve NodeManager to
> reuse good disks(which could be bad some time back).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
