[
https://issues.apache.org/jira/browse/YARN-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068678#comment-17068678
]
Peter Bacsko commented on YARN-10049:
-------------------------------------
Just minor nits:
1. {{if(res == 0)}} whitespace after "if"
2. Use {{Assert.assertEquals()}} everywhere to be consistent with existing code
OR replace everything with {{assertThat()}}. Current code is a bit all over the
place, assertj is mixed with junit. A small cleanup woudln't harm.
> FIFOOrderingPolicy Improvements
> -------------------------------
>
> Key: YARN-10049
> URL: https://issues.apache.org/jira/browse/YARN-10049
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Manikandan R
> Assignee: Manikandan R
> Priority: Major
> Attachments: YARN-10049.001.patch, YARN-10049.002.patch
>
>
> FIFOPolicy of FS does the following comparisons in addition to app priority
> comparison:
> 1. Using Start time
> 2. Using Name
> Scope of this jira is to achieve the same comparisons in FIFOOrderingPolicy
> of CS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]