[ https://issues.apache.org/jira/browse/YARN-6425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070048#comment-17070048 ]
Yousef Abu-Salah commented on YARN-6425: ---------------------------------------- *Justification for no new tests*: * The logging dump was moved outside of the read lock. All the existing unit tests for this method behave correctly which mean that the code operates correctly *Manual Steps Performed to make this Patch*: * All the unit tests in the package ' org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair' were run against this code change. This was done in NetBeans. The output of the run of unit tests is in the folder I shared with you and is called 'YARN-6425_unit_test_run ** '[^YARN-6425_unit_test_run.docx] > Move out FS state dump code out of method update() > -------------------------------------------------- > > Key: YARN-6425 > URL: https://issues.apache.org/jira/browse/YARN-6425 > Project: Hadoop YARN > Issue Type: Bug > Components: fairscheduler > Affects Versions: 2.9.0, 3.0.0-alpha2 > Reporter: Yufei Gu > Assignee: Yousef Abu-Salah > Priority: Major > Labels: newbie++ > Attachments: YARN-6425.001.patch, YARN-6425_unit_test_run.docx > > > Better to move out FS state dump code out of update() > {code} > if (LOG.isDebugEnabled()) { > if (--updatesToSkipForDebug < 0) { > updatesToSkipForDebug = UPDATE_DEBUG_FREQUENCY; > dumpSchedulerState(); > } > } > {code} > And, after that we should distinct between update call and update thread > duration like before YARN-6112. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org