[
https://issues.apache.org/jira/browse/YARN-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070517#comment-17070517
]
Yousef Abu-Salah commented on YARN-6551:
----------------------------------------
org.apache.hadoop.yarn.sls.SLSRunner.validateConfig(Configuration) makes
inefficient use of keySet iterator instead of entrySet iterator At
SLSRunner.java:keySet iterator instead of entrySet iterator At
SLSRunner.java:[line 229]"
In this method
1. The key set is used for comparison to members of another data structure.
2. The entry set is strings that do not have any context without the key.
Therefore the keys need to be accessed as a set for the iteration and then the
entries need to be considered as per the specific key they belong to.
> Validate SLS input
> ------------------
>
> Key: YARN-6551
> URL: https://issues.apache.org/jira/browse/YARN-6551
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler-load-simulator
> Reporter: Yufei Gu
> Assignee: Yousef Abu-Salah
> Priority: Major
> Labels: newbie
> Attachments: YARN-6551.002.patch
>
>
> SLS takes three different input formats, SLS, RUMEN, and SYN. Some values
> needs to be validated, e.g. node number cannot be negative.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
