[ 
https://issues.apache.org/jira/browse/YARN-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070811#comment-17070811
 ] 

Andras Gyori edited comment on YARN-10199 at 3/30/20, 9:14 AM:
---------------------------------------------------------------

Thank you [~pbacsko] for the feedback. I have applied your recommendations as 
detailed below:
 # stored the frequently used values in a local variable
 # removed the redundant GROUP_MAPPING checks, and simplified the boolean 
expression
 # 4. Fixed 

As for now, I hold the same position as you. Further granulation of this logic 
is not justified yet, however, it will be easier to migrate to a class-based 
approach from this state.


was (Author: gandras):
Thank you [~pbacsko] for the feedback. I have applied you advises as detailed 
below:
 # stored the frequently used values in a local variable
 # Removed the redundant GROUP_MAPPING checks, and simplified the boolean 
expression
 # 4. Fixed 

As for now, I hold the same position as you. Further granulation of this logic 
is not justified yet, however, it will be easier to migrate to a class-based 
approach from this state.

> Simplify UserGroupMappingPlacementRule#getPlacementForUser
> ----------------------------------------------------------
>
>                 Key: YARN-10199
>                 URL: https://issues.apache.org/jira/browse/YARN-10199
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>            Reporter: Andras Gyori
>            Assignee: Andras Gyori
>            Priority: Minor
>         Attachments: YARN-10199.001.patch, YARN-10199.002.patch, 
> YARN-10199.003.patch, YARN-10199.004.patch, YARN-10199.005.patch
>
>
> The UserGroupMappingPlacementRule#getPlacementForUser method, which is mainly 
> responsible for queue naming, contains deeply nested branches. In order to 
> provide an extendable mapping logic, the branches could be flattened and 
> simplified.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to