[
https://issues.apache.org/jira/browse/YARN-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17071043#comment-17071043
]
Adam Antal commented on YARN-10172:
-----------------------------------
Thanks for the patch [~cyrusjackson25]!
I have some minor nits here:
- Since it's not defined in the environment anymore, I think
{{APPLICATION_PLACEMENT_TYPE_CLASS}} or
{{APPLICATION_PLACEMENT_TYPE_CLASS_DEFAULT}} would be more appropriate there
(But I prefer the first since it's not a default, just a fallback in case the
env variable is not set. Also in {{YarnConfiguration}} class usually the
configuration's default are prefixed or suffixed with {{DEFAULT}}).
- Do you tried out the patch in a cluster? I see that there is a validation in
{{ApplicationPlacementAllocatorFactory}} that the class is available and it is
a subclass of a given type. I was wondering what could make debugging easier in
cases where the users try to find out how that class is actually instantiated.
INFO or DEBUG logging would be an overkill since it is a quite commonly created
class. I think I let it go, but if you can think of something, that would be
great.
> Default ApplicationPlacementType class should be configurable
> -------------------------------------------------------------
>
> Key: YARN-10172
> URL: https://issues.apache.org/jira/browse/YARN-10172
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Cyrus Jackson
> Assignee: Cyrus Jackson
> Priority: Minor
> Attachments: YARN-10172.001.patch, YARN-10172.002.patch
>
>
> This can be useful in scheduling apps based on the configured placement type
> class rather than resorting to LocalityAppPlacementAllocator
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
