[
https://issues.apache.org/jira/browse/YARN-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Teke updated YARN-10189:
---------------------------------
Attachment: YARN-10189.001.patch
> Code cleanup in LeveldbRMStateStore
> -----------------------------------
>
> Key: YARN-10189
> URL: https://issues.apache.org/jira/browse/YARN-10189
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Benjamin Teke
> Assignee: Benjamin Teke
> Priority: Minor
> Attachments: YARN-10189.001.patch, YARN-10189.POC001.patch,
> YARN-10189.POC002.patch
>
>
> Some things can be improved:
> * throws Exception declaration can be removed from
> LeveldbRMStateStore.initInternal methodÂ
> * key variable is redundant in LeveldbRMStateStore.dbStoreVersion
> * try can use automatic Resource management in
> LeveldbRMStateStore.loadReservationState/loadRMDTSecretManagerKeys/loadRMDTSecretManagerTokens/loadRMApps/...
> etc
> * there were some methods which were copied to LeveldbConfigurationStore
> (ie: openDatabase, storeVersion, loadVersion, CompactionTimerClass nested
> class), a helper class could be created to reduce the duplicated code
> * Any other cleanup
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
