[ https://issues.apache.org/jira/browse/YARN-10185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Antal resolved YARN-10185. ------------------------------- Resolution: Not A Problem > Container executor fields should be volatile > -------------------------------------------- > > Key: YARN-10185 > URL: https://issues.apache.org/jira/browse/YARN-10185 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn > Affects Versions: 3.3.0 > Reporter: Adam Antal > Assignee: Denes Gerencser > Priority: Major > > In YARN-7226 and YARN-10173 there two fields have been added to the > {{ContainerExecutor}} class. These fields are set through {{#setConf()}} only > once, but in a multithreaded environment the volatile keyword should be added > to ensure that the updated fields are used. > > Related piece of code: > {code:java} > private String[] whitelistVars; > private int exitCodeFileTimeout = > YarnConfiguration.DEFAULT_NM_CONTAINER_EXECUTOR_EXIT_FILE_TIMEOUT; > {code} > This can be hardly unit tested, but the bug could cause the UT added by > YARN-10173 to fail in a very small percentage. > Thanks for [~denes.gerencser] for finding this. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org