[
https://issues.apache.org/jira/browse/YARN-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077515#comment-17077515
]
Jonathan Hung commented on YARN-10212:
--------------------------------------
Thanks [~BilwaST]. A few comments:
* The javadoc for RM_AM_MAX_ATTEMPTS, can we change it to something like "The
maximum number of application attempts for an application, if unset by the user"
* Can we change the new config to at least have "am"? e.g.
yarn.resourcemanager.global.max-attempts to
yarn.resourcemanager.am.global-max-attempts?
* In ResourceManager.java I think we should validate both RM_AM_MAX_ATTEMPTS
and GLOBAL_RM_AM_MAX_ATTEMPTS (and change the message in the RuntimeExceptions
accordingly)
* In RMAppImpl, we need to split this case into two:
{noformat}
if (individualMaxAppAttempts <= 0 ||
individualMaxAppAttempts > globalMaxAppAttempts) {
this.maxAppAttempts = globalMaxAppAttempts; {noformat}
If individualMaxAppAttempts <= 0, set this.maxAppAttempts to
RM_AM_MAX_ATTEMPTS. If individualMaxAppAttempts > globalMaxAppAttempts, set
this.maxAppAttempts to globalMaxAppAttempts
* In the test case:
{noformat}
int[] rmAmMaxAttempts = new int[] { 8, 0 };{noformat}
I don't think 0 is a valid config for RM_AM_MAX_ATTEMPTS, can we set this to \{
8, 1 }?
* Based on the above changes we will need to change the expected values in the
test case from
{noformat}
int[][] expectedNums = new int[][]{
new int[]{ 9, 10, 10, 10 }, {noformat}
to
*
{noformat}
int[][] expectedNums = new int[][]{
new int[]{ 9, 10, 10, 8 }, {noformat}
> Create separate configuration for max global AM attempts
> --------------------------------------------------------
>
> Key: YARN-10212
> URL: https://issues.apache.org/jira/browse/YARN-10212
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Jonathan Hung
> Assignee: Bilwa S T
> Priority: Major
> Attachments: YARN-10212.001.patch
>
>
> Right now user's default max AM attempts is set to the same as global max AM
> attempts:
> {noformat}
> int globalMaxAppAttempts = conf.getInt(YarnConfiguration.RM_AM_MAX_ATTEMPTS,
> YarnConfiguration.DEFAULT_RM_AM_MAX_ATTEMPTS); {noformat}
> If we want to increase global max AM attempts, it will also increase the
> default. So we should create a separate global AM max attempts config to
> separate the two.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
