[
https://issues.apache.org/jira/browse/YARN-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17077722#comment-17077722
]
Siddharth Ahuja edited comment on YARN-10001 at 4/8/20, 1:23 AM:
-----------------------------------------------------------------
Hey [~snemeth], thank you very much for your review and commits! In regards to
branch-3.2 conflicts, I suspect the patch cannot be directly applied to
branch-3.2 because it does not contain the getLogs() method inside
InMemoryConfigurationStore.java. From inspection, this method comes along from
YARN-10002 which is quite a recent change. I have uploaded a patch for
branch-3.2 specifically that provides the method explanations for the existing
unimplemented methods in branch-3.2. However, as per YARN-10002 -
https://issues.apache.org/jira/browse/YARN-10002?focusedCommentId=17056066&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17056066,
there is a pending task to backport changes to branch-3.2. Therefore, when
that happens, getLogs() will come along but it won't have method explanations.
Therefore, do you want to wait for the backport of YARN-10002 first to
branch-3.2 and then commit my changes after that instead? I will let you think
about it :) Either way, you will have patches for both branches. Thanks again!
was (Author: sahuja):
Hey [~snemeth], thank you very much for your review and commits! In regards to
branch-3.2 conflicts, I suspect the patch cannot be directly applied to
branch-3.2 because it does not contain the getLogs() method inside
InMemoryConfigurationStore.java. From inspection, this method comes along from
YARN-10002 which is quite a recent change. I have uploaded a patch for
branch-3.2 specifically that provides the method explanations for the existing
unimplemented methods in branch-3.2. However, as per YARN-10002 -
https://issues.apache.org/jira/browse/YARN-10002?focusedCommentId=17056066&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17056066,
there is a pending task to backport changes to branch-3.2. Therefore, when
that happens, getLogs() will come along but it won't have method explanations.
Therefore, do you want to wait for the backport of YARN-10002 first to
branch-3.2 and then commit my changes after that instead? I will let you think
about it :) Thanks again!
> Add explanation of unimplemented methods in InMemoryConfigurationStore
> ----------------------------------------------------------------------
>
> Key: YARN-10001
> URL: https://issues.apache.org/jira/browse/YARN-10001
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Siddharth Ahuja
> Priority: Major
> Fix For: 3.3.0, 3.4.0
>
> Attachments: YARN-10001-branch-3.2.003.patch, YARN-10001.001.patch,
> YARN-10001.002.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
