[
https://issues.apache.org/jira/browse/YARN-9954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083602#comment-17083602
]
Jonathan Hung edited comment on YARN-9954 at 4/14/20, 8:53 PM:
---------------------------------------------------------------
Thanks [~BilwaST], a few comments
* Let's change {noformat}/**Max size of application tags.*/{noformat} ->
{noformat}/** Max number of application tags.*/{noformat}
* {{<description>Max size of application tags }} -> {{<description>Max number
of application tags }}
* Agree with Adam, let's wrap the IllegalArgumentExceptions as YarnException
via RPCUtil.getRemoteException
Also, this jira will be useful to have in older minor versions. But we cannot
remove @Evolving fields within a minor version. Shall we open a separate jira
to remove these fields, and in this jira set DEFAULT_RM_APPLICATION_MAX_TAGS to
APPLICATION_MAX_TAGS and set DEFAULT_RM_APPLICATION_MAX_TAG_LENGTH to
APPLICATION_MAX_TAG_LENGTH ?
was (Author: jhung):
Thanks [~BilwaST], a few comments
* Let's change {{/** Max size of application tags.*/}} -> {{/** Max number of
application tags.*/}}
* {{<description>Max size of application tags }} -> {{<description>Max number
of application tags }}
* Agree with Adam, let's wrap the IllegalArgumentExceptions as YarnException
via RPCUtil.getRemoteException
Also, this jira will be useful to have in older minor versions. But we cannot
remove @Evolving fields within a minor version. Shall we open a separate jira
to remove these fields, and in this jira set DEFAULT_RM_APPLICATION_MAX_TAGS to
APPLICATION_MAX_TAGS and set DEFAULT_RM_APPLICATION_MAX_TAG_LENGTH to
APPLICATION_MAX_TAG_LENGTH ?
> Configurable max application tags and max tag length
> ----------------------------------------------------
>
> Key: YARN-9954
> URL: https://issues.apache.org/jira/browse/YARN-9954
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Jonathan Hung
> Assignee: Bilwa S T
> Priority: Major
> Attachments: YARN-9954.001.patch
>
>
> Currently max tags and max tag length is hardcoded, it should be configurable
> {noformat}
> @Evolving
> public static final int APPLICATION_MAX_TAGS = 10;
> @Evolving
> public static final int APPLICATION_MAX_TAG_LENGTH = 100; {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
