[
https://issues.apache.org/jira/browse/YARN-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099049#comment-17099049
]
Hudson commented on YARN-10256:
-------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18213 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/18213/])
YARN-10256. Refactor (jeagles: rev f5081a9a5d51fe781da97f07ac4dca8dd49c98e2)
* (edit)
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/scheduler/TestContainerSchedulerQueuing.java
> Refactor
> TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic
> -------------------------------------------------------------------------------------------
>
> Key: YARN-10256
> URL: https://issues.apache.org/jira/browse/YARN-10256
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: refactoring, unit-test
> Attachments: YARN-10256.001.patch
>
>
> In 3.x,
> {{TestContainerSchedulerQueuing.testContainerUpdateExecTypeGuaranteedToOpportunistic}}
> has redundant assertions. Since the UT throws timeout exception,
> {{GenericTestsUtils.waitFor()}} guarantees that the predicate is met
> successfully. Otherwise, the UT would throw a timeout exception.
> The redundant loop causes confusion in understanding the test unit and may
> increase the possibility of failure in case the container terminates
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
