[
https://issues.apache.org/jira/browse/YARN-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114350#comment-17114350
]
Jonathan Hung edited comment on YARN-6492 at 5/22/20, 11:34 PM:
----------------------------------------------------------------
Thank you [~maniraj...@gmail.com]. Some more comments:
* Delete printlns in PartitionQueueMetrics
* Delete VisibleForTesting import in CSQueueMetrics
* Can we address the checkstyle/whitespace/javadoc/findbugs/asflicense issues?
* TestCapacitySchedulerAutoQueueCreation failure looks related to this patch.
TestFairSchedulerPreemption passes locally for me.
Ran some tests on a live cluster, everything looks good. I noticed we don't
have CSQueueMetrics for partitioned metrics, it would be good to have those,
but we can address this in another jira.
was (Author: jhung):
Thank you [~maniraj...@gmail.com]. Some more comments:
* Delete printlns in PartitionQueueMetrics
* Delete VisibleForTesting import in CSQueueMetrics
* Can we address the checkstyle/whitespace/javadoc/findbugs/asflicense issues?
* Not sure if unit test failures are related. Let's see the next jenkins run.
Ran some tests on a live cluster, everything looks good. I noticed we don't
have CSQueueMetrics for partitioned metrics, it would be good to have those,
but we can address this in another jira.
> Generate queue metrics for each partition
> -----------------------------------------
>
> Key: YARN-6492
> URL: https://issues.apache.org/jira/browse/YARN-6492
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacity scheduler
> Reporter: Jonathan Hung
> Assignee: Manikandan R
> Priority: Major
> Attachments: PartitionQueueMetrics_default_partition.txt,
> PartitionQueueMetrics_x_partition.txt, PartitionQueueMetrics_y_partition.txt,
> YARN-6492.001.patch, YARN-6492.002.patch, YARN-6492.003.patch,
> YARN-6492.004.patch, YARN-6492.005.WIP.patch, YARN-6492.006.WIP.patch,
> YARN-6492.007.WIP.patch, YARN-6492.008.WIP.patch, YARN-6492.009.WIP.patch,
> YARN-6492.010.WIP.patch, partition_metrics.txt
>
>
> We are interested in having queue metrics for all partitions. Right now each
> queue has one QueueMetrics object which captures metrics either in default
> partition or across all partitions. (After YARN-6467 it will be in default
> partition)
> But having the partition metrics would be very useful.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
