[ 
https://issues.apache.org/jira/browse/YARN-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116138#comment-17116138
 ] 

Manikandan R commented on YARN-6492:
------------------------------------

Addressed all comments, covered almost all 
checkstyle/whitespace/javadoc/findbugs/asflicense issues. 
TestCapacitySchedulerAutoQueueCreation failures are happening only for test 
cases which tries to mock the rm twice. 
TestCapacitySchedulerAutoQueueCreation#setupSchedulerInstance does this. Will 
need to check the reason even though MockRM shutdown the metrics system and 
clear queue metrics.
{quote}On line 2539 of TestNodeLabelContainerAllocation, should
{quote}
Behaviour was same even without this patch when user metrics has been enabled. 
Attached junits patch explains this. However, did some changes in 
LeafQueue.java as part of this patch as well. In both ways, 
UsersManager#computeUserLimit() does the actual calculation. Can we handle this 
separately?

Good to see the positive results on live cluster. Yes, we can handle 
CSQueueMetrics for partitioned metrics in separate JIRA.

> Generate queue metrics for each partition
> -----------------------------------------
>
>                 Key: YARN-6492
>                 URL: https://issues.apache.org/jira/browse/YARN-6492
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacity scheduler
>            Reporter: Jonathan Hung
>            Assignee: Manikandan R
>            Priority: Major
>         Attachments: PartitionQueueMetrics_default_partition.txt, 
> PartitionQueueMetrics_x_partition.txt, PartitionQueueMetrics_y_partition.txt, 
> YARN-6492-junits.patch, YARN-6492.001.patch, YARN-6492.002.patch, 
> YARN-6492.003.patch, YARN-6492.004.patch, YARN-6492.005.WIP.patch, 
> YARN-6492.006.WIP.patch, YARN-6492.007.WIP.patch, YARN-6492.008.WIP.patch, 
> YARN-6492.009.WIP.patch, YARN-6492.010.WIP.patch, partition_metrics.txt
>
>
> We are interested in having queue metrics for all partitions. Right now each 
> queue has one QueueMetrics object which captures metrics either in default 
> partition or across all partitions. (After YARN-6467 it will be in default 
> partition)
> But having the partition metrics would be very useful.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to