[ 
https://issues.apache.org/jira/browse/YARN-10274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118651#comment-17118651
 ] 

Gergely Pollak commented on YARN-10274:
---------------------------------------

Kept QueueMapping, and replaced all uses of QueueMappingEntity with 
QueueMappings. The main difference between the two classes is QueueMapping uses 
a builder to create an object, while QueueMappingEntity had multiple 
constructors. For now I've kept the builder approach, however it might need a 
revisit at a later point since the Builder creates a builder object, which then 
creates the actual object, which means we store every data 2 times for an 
object with like 4 fields. This might be a bit of an overkill.

> Merge QueueMapping and QueueMappingEntity
> -----------------------------------------
>
>                 Key: YARN-10274
>                 URL: https://issues.apache.org/jira/browse/YARN-10274
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: yarn
>            Reporter: Gergely Pollak
>            Assignee: Gergely Pollak
>            Priority: Major
>
> The role, usage and internal behaviour of these classes are almost identical, 
> but it makes no sense to keep both of them. One is used by UserGroup 
> placement rule definitions the other is used by Application placement rules.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to