[ 
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119910#comment-17119910
 ] 

Jim Brennan commented on YARN-9903:
-----------------------------------

[~tarunparimi], [~pbacsko] we have been reviewing internal Verizon Media 
(Yahoo) code changes, and this is one of them.  We changed to allow 
reservations continue looking for labeled nodes.  We have been running with 
this change in our branch-2.8 based code since 2016.  I will submit a patch for 
trunk here.  This seems more relevant to what we did compared to YARN-10283.
cc: [~epayne]

> Support reservations continue looking for Node Labels
> -----------------------------------------------------
>
>                 Key: YARN-9903
>                 URL: https://issues.apache.org/jira/browse/YARN-9903
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Tarun Parimi
>            Priority: Major
>
> YARN-1769 brought in reservations continue looking feature which improves the 
> several resource reservation scenarios. However, it is not handled currently 
> when nodes have a label assigned to them. This is useful and in many cases 
> necessary even for Node Labels. So we should look to support this for node 
> labels also.
> For example, in AbstractCSQueue.java, we have the below TODO.
> {code:java}
> // TODO, now only consider reservation cases when the node has no label 
> if (this.reservationsContinueLooking && nodePartition.equals( 
> RMNodeLabelsManager.NO_LABEL) && Resources.greaterThan( resourceCalculator, 
> clusterResource, resourceCouldBeUnreserved, Resources.none())) {
> {code}
> cc [~sunilg]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to