[ 
https://issues.apache.org/jira/browse/YARN-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125136#comment-17125136
 ] 

Eric Payne commented on YARN-9903:
----------------------------------

As [~Jim_Brennan] pointed out, our usage of node labels is somewhat limited. On 
the one hand, we have a few clusters with node labels, and jobs are constantly 
being run in those queues. However, we don't use many features that are 
provided by node labels. For example, we only use exclusive node labels.

Having said that, I think that this feature is safe. I don't think the various 
node label features would have much of an effect on un-scheduling and 
re-scheduling reservations. And, as Jim says, we have been using this fix for a 
long time internally.

> Support reservations continue looking for Node Labels
> -----------------------------------------------------
>
>                 Key: YARN-9903
>                 URL: https://issues.apache.org/jira/browse/YARN-9903
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Tarun Parimi
>            Assignee: Jim Brennan
>            Priority: Major
>         Attachments: YARN-9903.001.patch, YARN-9903.002.patch
>
>
> YARN-1769 brought in reservations continue looking feature which improves the 
> several resource reservation scenarios. However, it is not handled currently 
> when nodes have a label assigned to them. This is useful and in many cases 
> necessary even for Node Labels. So we should look to support this for node 
> labels also.
> For example, in AbstractCSQueue.java, we have the below TODO.
> {code:java}
> // TODO, now only consider reservation cases when the node has no label 
> if (this.reservationsContinueLooking && nodePartition.equals( 
> RMNodeLabelsManager.NO_LABEL) && Resources.greaterThan( resourceCalculator, 
> clusterResource, resourceCouldBeUnreserved, Resources.none())) {
> {code}
> cc [~sunilg]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to