Eric Payne commented on YARN-10300:

Thanks for raising this issue and for providing the fix.

The code changes look good. However, I have a couple of comments on the unit 

The unit test succeeds with and without the changes. The unit test tests 
returns the current host, not whether {{RMAppManager#createAppSummary}} fills 
in the AM host name prior to node heartbeat.

I don't know how hard it would be to call {{RMAppManager#createAppSummary}} 
directly, but if it's possible, I think the unit test should do that and then 
check that the SummaryBuilder has the host and port filled in. Do you think 
that's possible?

> appMasterHost not set in RM ApplicationSummary when AM fails before first 
> heartbeat
> -----------------------------------------------------------------------------------
>                 Key: YARN-10300
>                 URL: https://issues.apache.org/jira/browse/YARN-10300
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>            Priority: Major
>         Attachments: YARN-10300.001.patch, YARN-10300.002.patch
> {noformat}
> 2020-05-23 14:09:10,086 INFO resourcemanager.RMAppManager$ApplicationSummary: 
> appId=application_1586003420099_12444961,name=job_name,user=username,queue=queuename,state=FAILED,trackingUrl=https
> ://cluster:port/applicationhistory/app/application_1586003420099_12444961,appMasterHost=N/A,startTime=1590241207309,finishTime=1590242950085,finalStatus=FAILED,memorySeconds=13750,vcoreSeconds=67,preemptedMemorySeconds=0,preemptedVcoreSeconds=0,preemptedAMContainers=0,preemptedNonAMContainers=0,preemptedResources=<memory:0\,
>  vCores:0>,applicationType=MAPREDUCE
> {noformat}
> {{appMasterHost=N/A}} should have the AM hostname instead of N/A

This message was sent by Atlassian Jira

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to