[
https://issues.apache.org/jira/browse/YARN-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126645#comment-17126645
]
Szilard Nemeth edited comment on YARN-9930 at 6/5/20, 10:36 AM:
----------------------------------------------------------------
Hi [~pbacsko],
1. Overall feedback for the design:
I like the approach so from my POV, the design is fine.
I think it's very straightforward that you created a separate class of
CSMaxRunningAppsEnforcer.
What about keeping it for this round, and after this jira is merged, work on a
followup jira that refactors this and make an abstract parent class for
CSMaxRunningAppsEnforcer MaxRunningAppsEnforcer?
You also mentioned about a separate property named as
'yarn.scheduler.capacity.maxrunningapps.reject' but I don't see it in the
latest patch.
2. Review comments:
AbstractCSQueue: Typo in name 'queueMaxRunninApps'.
was (Author: snemeth):
Hi [~pbacsko],
1. Overall feedback for the design:
I like the approach so from my POV, the design is fine.
I think it's very straightforward that you created a separate class of
CSMaxRunningAppsEnforcer.
What about keeping it for this round, and after this jira is merged, work on a
followup jira that refactors this and make an abstract parent class for
CSMaxRunningAppsEnforcer MaxRunningAppsEnforcer?
2. Review comments:
AbstractCSQueue: Typo in name 'queueMaxRunninApps'.
> Support max running app logic for CapacityScheduler
> ---------------------------------------------------
>
> Key: YARN-9930
> URL: https://issues.apache.org/jira/browse/YARN-9930
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler, capacityscheduler
> Affects Versions: 3.1.0, 3.1.1
> Reporter: zhoukang
> Assignee: zhoukang
> Priority: Major
> Attachments: YARN-9930-POC01.patch, YARN-9930-POC02.patch,
> YARN-9930-POC03.patch, YARN-9930-POC04.patch, YARN-9930-POC05.patch
>
>
> In FairScheduler, there has limitation for max running which will let
> application pending.
> But in CapacityScheduler there has no feature like max running app.Only got
> max app,and jobs will be rejected directly on client.
> This jira i want to implement this semantic for CapacityScheduler.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
